Skip to content

replace the include tag with the include() function #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2020
Merged

replace the include tag with the include() function #379

merged 1 commit into from
Jan 2, 2020

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 1, 2020

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
Documentation
License MIT

What's in this PR?

Replaces usages of the Twig include tag with the include() function.

Why?

Twig best practice is to use the function instead of the tag:

It is recommended to use the include function instead as it provides the same features with a bit more flexibility [...]

see https://twig.symfony.com/doc/3.x/tags/include.html

@dbu dbu merged commit 66a40e5 into master Jan 2, 2020
@dbu dbu deleted the replace-include branch January 2, 2020 09:23
@dbu
Copy link
Collaborator

dbu commented Jan 2, 2020

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xabbuh @dbu